From 205b2beae31b3ca69ed8a608f4d9ea7945481882 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Mond=C3=A9jar=20Rubio?= Date: Tue, 30 Jan 2024 10:30:47 +0100 Subject: [PATCH 1/2] Fix CI --- .github/workflows/book.yml | 2 +- .github/workflows/ci.yml | 2 +- src/use_broadcast_channel.rs | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/book.yml b/.github/workflows/book.yml index 35ca411..fc14e1a 100644 --- a/.github/workflows/book.yml +++ b/.github/workflows/book.yml @@ -30,7 +30,7 @@ jobs: - name: Install mdbook II run: | cargo binstall -y mdbook-cmdrun - cargo binstall -y trunk + cargo binstall -y trunk@0.17.5 rustup target add wasm32-unknown-unknown - name: Setup Pages id: pages diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 38f8cde..d06c55f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -46,7 +46,7 @@ jobs: - name: Install mdbook II run: | cargo binstall -y mdbook-cmdrun - cargo binstall -y trunk + cargo binstall -y trunk@0.17.5 rustup target add wasm32-unknown-unknown - name: Setup Pages id: pages diff --git a/src/use_broadcast_channel.rs b/src/use_broadcast_channel.rs index af70b4a..010815b 100644 --- a/src/use_broadcast_channel.rs +++ b/src/use_broadcast_channel.rs @@ -103,8 +103,6 @@ where }; let close = { - let channel = channel.clone(); - move || { if let Some(channel) = channel.get_untracked() { channel.close(); @@ -153,7 +151,7 @@ where close(); }); - return UseBroadcastChannelReturn { + UseBroadcastChannelReturn { is_supported, channel: channel.into(), message: message.into(), @@ -161,7 +159,7 @@ where close, error: error.into(), is_closed: is_closed.into(), - }; + } } /// Return type of [`use_broadcast_channel`]. From f5f3aad26aad77c28730d192e2d5216a54ffa4b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=81lvaro=20Mond=C3=A9jar=20Rubio?= Date: Tue, 30 Jan 2024 10:41:19 +0100 Subject: [PATCH 2/2] Fix error --- examples/use_storage/src/main.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/examples/use_storage/src/main.rs b/examples/use_storage/src/main.rs index c1a98fa..0d38d7b 100644 --- a/examples/use_storage/src/main.rs +++ b/examples/use_storage/src/main.rs @@ -1,6 +1,7 @@ use leptos::*; use leptos_use::docs::{demo_or_body, Note}; -use leptos_use::storage::{use_local_storage, JsonCodec}; +use leptos_use::storage::use_local_storage; +use leptos_use::utils::JsonCodec; use serde::{Deserialize, Serialize}; #[derive(Serialize, Deserialize, Clone, Debug, PartialEq)]