mirror of
https://github.com/adoyle0/thaw.git
synced 2025-01-22 22:09:22 -05:00
icon missaligment in message fix (#194)
* Hi @luoxiaozero,
I've just noticed the same issue as described here (https://github.com/thaw-ui/thaw/issues/190) and tracked it down to tailwindcss. In the output.css generated by it we have:
```
/*
1. Make replaced elements `display: block` by default. (https://github.com/mozdevs/cssremedy/issues/14)
2. Add `vertical-align: middle` to align replaced elements more sensibly by default. (https://github.com/jensimmons/cssremedy/issues/14#issuecomment-634934210)
This can trigger a poorly considered lint error in some tools but is included by design.
*/
img,
svg,
video,
canvas,
audio,
iframe,
embed,
object {
display: block;
/* 1 */
vertical-align: middle;
/* 2 */
}
```
Your recent change sets the display to inline-block (983e85728a
) and this collides with the 'vertical-align' set by tailwindcss.
Changing the vertical-align property to 'top' fixes the misalignment so I think the simplest fix is to add 'vertical-align: top' to icon.css. I don't see it affecting anything else so it should be safe.
* icon missaligment fix
This commit is contained in:
parent
3edb401f0a
commit
9259bdc723
2 changed files with 3 additions and 1 deletions
|
@ -1,3 +1,4 @@
|
|||
.thaw-icon {
|
||||
display: inline-block;
|
||||
}
|
||||
vertical-align: baseline;
|
||||
}
|
||||
|
|
|
@ -105,6 +105,7 @@
|
|||
}
|
||||
|
||||
.thaw-message__icon {
|
||||
display: flex;
|
||||
width: 20px;
|
||||
height: 20px;
|
||||
margin-right: 10px;
|
||||
|
|
Loading…
Add table
Reference in a new issue