adam/thaw
1
0
Fork 0
mirror of https://github.com/adoyle0/thaw.git synced 2025-02-02 08:34:15 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Teleport component cleanup

Browse source
This commit is contained in:
luoxiao 2023-11-11 11:49:47 +08:00
parent 7b44974533
commit f5e6eae558
2 changed files with 28 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
src/components/binder/mod.rs
View file

@ -158,20 +158,19 @@ fn FollowerContainer<El: ElementDescriptor + Clone + 'static>(
}
is_show
});
let children = html::div()
.classes("thaw-binder-follower-container")
.style("display", move || (!is_show.get()).then_some("none"))
.child(
html::div()
.classes("thaw-binder-follower-content")
.node_ref(content_ref)
.attr("style", move || content_style.get())
.child(children()),
);
view! {
<Teleport>
<div class="thaw-binder-follower-container" style=move || {
if is_show.get() {
""
} else {
"display: none;"
}
}>
<div class="thaw-binder-follower-content" ref=content_ref style=move || content_style.get()>
{children()}
</div>
</div>
</Teleport>
<Teleport element=children />
}
}

26
src/teleport/mod.rs
View file

@ -1,30 +1,36 @@
use cfg_if::cfg_if;
use leptos::*;
use leptos::{html::AnyElement, *};
/// https://github.com/solidjs/solid/blob/main/packages/solid/web/src/index.ts#L56
#[component]
pub fn Teleport(
#[prop(into, optional)] mount: Option<web_sys::Element>,
children: Children,
#[prop(optional, into)] element: Option<HtmlElement<AnyElement>>,
#[prop(optional)] children: Option<Children>,
) -> impl IntoView {
cfg_if! { if #[cfg(target_arch = "wasm32")] {
use leptos::{
wasm_bindgen::JsCast,
leptos_dom::Mountable
};
use leptos::wasm_bindgen::JsCast;
let mount = mount.unwrap_or_else(|| {
document()
.body()
.expect("body element not to exist")
.unchecked_into()
});
let node = children().into_view();
let node = node.get_mountable_node();
_ = mount.append_child(&node);
let render_root = if let Some(element) = element {
element
} else if let Some(children) = children {
html::div().child(children()).into_any()
} else {
return;
};
_ = mount.append_child(&render_root);
on_cleanup(move || {
_ = mount.remove_child(&node);
_ = mount.remove_child(&render_root);
});
} else {
_ = mount;
_ = element;
_ = children;
}}
}